fix: Fixes the thread sorting algorithm

quack-ai · Dec 21, 2023 · 778879a · 778879a
1 parent ca20609
commit 778879a
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/app/services/github.py b/src/app/services/github.py
@@ -266,13 +266,14 @@ def arrange_in_threads(comments: List[Dict[str, Any]]) -> List[List[int]]:
             _thread = [_id]
             unused_nodes.remove(_id)
             while isinstance(next_map.get(_thread[-1]), int):
-                _thread.append(next_map[_thread[-1]])
                 unused_nodes.remove(next_map[_thread[-1]])
+                _thread.append(next_map[_thread[-1]])
             while isinstance(prev_map.get(_thread[0]), int):
-                _thread.insert(0, prev_map[_thread[0]])
                 unused_nodes.remove(prev_map[_thread[0]])
+                _thread.insert(0, prev_map[_thread[0]])
             threads.append(_thread)
 
+        # Sort threads by the ID of the first comment
         return sorted(threads, key=itemgetter(0))
 
     def fetch_pull_comments_from_repo(