Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding new octave #16

Merged
merged 16 commits into from
Mar 12, 2024
Merged

adding new octave #16

merged 16 commits into from
Mar 12, 2024

Conversation

nulinspiratie
Copy link
Contributor

@nulinspiratie nulinspiratie commented Mar 6, 2024

See the markdown file for a demonstration

Remaining To do items

  • Add base class BaseFrequencyConverter
  • Add IF_outputs to OctaveDownConverter
  • Write Octave.initialize_default_connectivity
  • Add Octave-related config entries to channels
  • Add tests
    • Test Octave loading
  • Consider including singleton QMM instance
  • Add Literal type to QuAM type checking
  • Avoid breaking change for FrequencyConverter
  • Add documentation

Implementation choices

  • I avoid using the default connectivity "connectivity": "con1". Instead, I always define all connections.
    The reason is more flexibility, plus the OPX connectivity is defined in the channel, not the frequency converters
  • I ignored config RF_inputs/id/RF_source as "RF_in" seems to be the only option.
  • When an RF_output only uses a single OPX output, I attach it to I_connection
  • When LO_frequency is not specified, I don't add the frequency converter to the config

Future updates

  • Potentially incorporate QMM, QM, QmOctave into Octave

@nulinspiratie nulinspiratie requested review from yomach and TheoLaudatQM and removed request for yomach and TheoLaudatQM March 8, 2024 16:51
Copy link
Collaborator

@yomach yomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's discuss the changes in 2.4.0

@nulinspiratie nulinspiratie merged commit a609301 into main Mar 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants