-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding new octave #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nulinspiratie
requested review from
yomach and
TheoLaudatQM
and removed request for
yomach and
TheoLaudatQM
March 8, 2024 16:51
yomach
approved these changes
Mar 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's discuss the changes in 2.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the markdown file for a demonstration
Remaining To do items
BaseFrequencyConverter
IF_outputs
toOctaveDownConverter
Octave.initialize_default_connectivity
FrequencyConverter
Implementation choices
"connectivity": "con1"
. Instead, I always define all connections.The reason is more flexibility, plus the OPX connectivity is defined in the channel, not the frequency converters
RF_inputs/id/RF_source
as"RF_in"
seems to be the only option.RF_output
only uses a single OPX output, I attach it toI_connection
LO_frequency
is not specified, I don't add the frequency converter to the configFuture updates
QMM
,QM
,QmOctave
intoOctave