Merge pull request #14 from qua-platform/fix/pulse-id

Change pulse.id from class variable to instance variable

CHANGELOG.md

@@ -17,6 +17,7 @@
   This happens if channel.id is not set, and channel.parent does not have a name either
 - `Pulse.axis_angle` is now in radians instead of degrees.
 - Channel offsets (e.g. `SingleChannel.opx_output_offset`) is None by default (see note in Fixed)
+- `Pulse.id` is now an instance variable instead of a class variable
 
 ### Fixed
 - Don't raise instantiation error when required_type is not a class

quam/components/pulses.py

@@ -52,10 +52,9 @@ class Pulse(QuamComponent):
         The digital marker label is defined as `"{channel_name}.{pulse_name}.dm"`.
 
     """
-
-    id: ClassVar[str] = None
     operation: ClassVar[str] = "control"
     length: int
+    id: str = None
 
     digital_marker: Union[str, List[Tuple[int, int]]] = None
 

tests/components/test_pulses.py

@@ -14,6 +14,7 @@ def test_drag_pulse():
     assert drag_pulse.operation == "control"
     assert drag_pulse.length == 20
     assert drag_pulse.get_attrs() == {
+        "id": None,
         "length": 20,
         "axis_angle": 0.0,
         "digital_marker": None,