Skip to content

Commit

Permalink
Change pulse.id from class variable to instance variable
Browse files Browse the repository at this point in the history
  • Loading branch information
nulinspiratie committed Feb 21, 2024
1 parent a3fa57f commit df0e849
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
This happens if channel.id is not set, and channel.parent does not have a name either
- `Pulse.axis_angle` is now in radians instead of degrees.
- Channel offsets (e.g. `SingleChannel.opx_output_offset`) is None by default (see note in Fixed)
- `Pulse.id` is now an instance variable instead of a class variable

### Fixed
- Don't raise instantiation error when required_type is not a class
Expand Down
3 changes: 1 addition & 2 deletions quam/components/pulses.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,9 @@ class Pulse(QuamComponent):
The digital marker label is defined as `"{channel_name}.{pulse_name}.dm"`.
"""

id: ClassVar[str] = None
operation: ClassVar[str] = "control"
length: int
id: str = None

digital_marker: Union[str, List[Tuple[int, int]]] = None

Expand Down

0 comments on commit df0e849

Please sign in to comment.