Merge pull request #69 from qua-platform/fix/octave-rf_input_2-external

Fix: Set default LO_source for Octave RF input 2 to "external"

CHANGELOG.md

@@ -6,6 +6,7 @@
 
 ### Changed
 - Allow `QuamBase.get_reference(attr)` to return a reference of one of its attributes
+- Octave RF input 2 has `LO_source = "external"` by default
 
 ### Fixed
 - Fix quam object instantiation error when a parameter type uses pipe operator
@@ -16,6 +17,7 @@
 - Fix warning messages in QuamComponent instantiation
 
 
+
 ## [0.3.3]
 ### Added
 - Added the following parameters to `IQChannel`: `RF_frequency`, `LO_frequency`, `intermediate_frequency`

quam/components/octave.py

@@ -97,7 +97,10 @@ def initialize_frequency_converters(self):
             )
 
         for idx in range(1, 3):
-            self.RF_inputs[idx] = OctaveDownConverter(id=idx, LO_frequency=None)
+            LO_source = "internal" if idx == 1 else "external"
+            self.RF_inputs[idx] = OctaveDownConverter(
+                id=idx, LO_frequency=None, LO_source=LO_source
+            )
 
     def get_octave_config(self) -> QmOctaveConfig:
         """Return a QmOctaveConfig object with the current Octave configuration."""

tests/components/test_octave.py

@@ -329,7 +329,7 @@ def test_load_octave(octave):
     d_expected = {
         "__class__": "test_octave.OctaveQuAM",
         "octave": {
-            "RF_inputs": {1: {"id": 1}, 2: {"id": 2}},
+            "RF_inputs": {1: {"id": 1}, 2: {"id": 2, "LO_source": "external"}},
             "RF_outputs": {
                 1: {"id": 1},
                 2: {"id": 2},