Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix qcodes driver for qm-qua==1.2.1 #251

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

TheoLaudatQM
Copy link
Contributor

Fix the OPX qcodes driver to be compatible with qm-qua 1.2.1 (apparently the serialized stream processing format change a bit compared to previous versions)

@TheoLaudatQM TheoLaudatQM requested a review from yomach November 30, 2024 09:42
Copy link

Unit Test Results

413 tests   404 ✔️  45s ⏱️
    1 suites      9 💤
    1 files        0

Results for commit be39f04.

Copy link
Collaborator

@yomach yomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add testing for that...
Is it now working on both 1.2.1 and 1.1.7?

@TheoLaudatQM
Copy link
Contributor Author

Yes agree...
I just added a simple check if hasattr(gene.values[2].list_value.values[1], "list_value"): I think that before 1.2.1 we always had a list_value, but maybe for simplification, now we can have directly a string_value if there is nothing else after...

@TheoLaudatQM TheoLaudatQM merged commit 54b2b16 into main Dec 2, 2024
2 checks passed
@TheoLaudatQM TheoLaudatQM deleted the fix/qcodes_qmqua1.2.1 branch December 2, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants