Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Move DEFAULT_DATA_PROCESSORS #216

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

nulinspiratie
Copy link
Contributor

Move DEFAULT_DATA_PROCESSORS from data_processors.py to __init__.py,

In response to comment by @yomach

@nulinspiratie nulinspiratie requested a review from yomach May 18, 2024 03:59
Copy link

github-actions bot commented May 18, 2024

Unit Test Results

382 tests   379 ✔️  43s ⏱️
    1 suites      3 💤
    1 files        0

Results for commit e684be0.

♻️ This comment has been updated with latest results.

@nulinspiratie
Copy link
Contributor Author

Actually, I can't get the tests working. The problem is the following:

  • results/data_handler/data_handler.py needs DEFAULT_DATA_PROCESSORS for one of its class attributes.
  • DEFAULT_DATA_PROCESSORS is defined in results/data_handler/__init__.py
  • results/data_handler/__init__.py loads results/data_handler/data_handler.py
    This leads to a circular import.

I can't see a way around it. @yomach if you can't either then I suggest to cancel this PR, and keep DEFAULT_DATA_PROCESSORS in data_processors.py

@yomach
Copy link
Collaborator

yomach commented May 21, 2024

@nulinspiratie See my changes.
Also note, I've put all of the __all__ under the __init__.py, as it is more customary to do

deanpoulos
deanpoulos previously approved these changes Jun 11, 2024
@deanpoulos deanpoulos dismissed their stale review June 11, 2024 05:54

Accident

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants