-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qcodes driver fix #190
Open
TheoLaudatQM
wants to merge
4
commits into
main
Choose a base branch
from
qcodes_driver_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Qcodes driver fix #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @yomach, this relates to this issue, is it what you had in mind? |
I'm not sure. Since we didn't reproduce the issue locally I don't know if this fixed it. We can try to ask the author of that issue in the ticket. I'll ping him |
TheoLaudatQM
force-pushed
the
qcodes_driver_fix
branch
from
April 18, 2024 17:05
a1c42a3
to
b027e47
Compare
yomach
reviewed
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog?
Here we are waiting for the response from the guy who asked for the PR.
I won't merge until he approves and I just rebased it on the new version, sorry for the useless notification...
Envoyé à partir de Outlook pour Android<https://aka.ms/AAb9ysg>
…________________________________
From: Yoav Romach ***@***.***>
Sent: Thursday, April 18, 2024 7:08:10 PM
To: qua-platform/py-qua-tools ***@***.***>
Cc: Theo Laudat ***@***.***>; Author ***@***.***>
Subject: Re: [qua-platform/py-qua-tools] Qcodes driver fix (PR #190)
@yomach commented on this pull request.
Changelog?
—
Reply to this email directly, view it on GitHub<#190 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXR3HVT7QHPXUWQMO3KXHE3Y574XVAVCNFSM6AAAAABE5EIYI2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMBZGQ2TANRUGY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qua_program replaced by a field
numpy import fix