-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a setup.py file for installation and packaging #18
base: master
Are you sure you want to change the base?
Conversation
…andard python setup.py install approach
…py2js/msg/fe5b9df5b9273591 , Ondrej Certik should be listed as the main author for the setup script.
…ain files required for installation that the default template omits
… to be manually parsed.
…hash is not present in the version string
…after installation
Thanks a lot for the patch. I tried it on Ubuntu 11.10 and I got:
Does |
Also, try to run tests:
I run them in your branch by using the generated files from the master and some of them failed for me. Do all tests pass for you? |
Make and tests work for me on Ubuntu. I have provided a list of commands to produce the environment in an AWS EC2 instance. Is it acceptable to require an install before make will work? I have also tested on Windows 7 and all tests pass. Note that it took a recent copy of v8 compiled from svn for the tests to pass. Otherwise roughly 23 failed.
|
Currently py2js works without having to use "sudo" nor to install it. (Of course, you should be able to install it as well.) It must be possible to improve your patch to make this work. I am currently busy to figure it out, but if you get stuck, I'll try to find some time for it. Here is the tests log from the latest master with Ubuntu's v8: https://gist.github.com/1383861 as you can see, all tests pass. Can you post here what tests fail for you with Ubuntu's v8? Does it fail only with your branch or also with master? Thanks again for all your work. |
Ondřej, I don't think it will be very difficult to adjust the patch. I think the Makefile just needs another command or two to shuffle some files around. I will report back about the tests. I don't think there was a problem though. I think it was just user error on my part. I got it all to work when I installed from vanilla source. So that leads me to believe I messed something up when I was setting up the ec2 instance the first time. |
I think so too, it should be simple. If you do it, then I can test that things still work on my machine and I can merge this patch in. |
No description provided.