Skip to content

Commit

Permalink
#56 fix: column issue in bookmark list and update changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
pbek committed Feb 7, 2024
1 parent 6268587 commit 629be39
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 21 deletions.
11 changes: 10 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,17 @@
# QOwnNotes Web Companion Changelog

## 2024.2.1
- an issue with the columns in the bookmarks list was fixed
(for [#56](https://github.com/qownnotes/web-companion/issues/56))
- the minimum version for Firefox was raised to 109, because of manifest version 3
(for [#56](https://github.com/qownnotes/web-companion/issues/56))
- `host_permissions` were removed from the manifest file for Chrome, because they are not needed
(for [#56](https://github.com/qownnotes/web-companion/issues/56))
- added a more translation

## 2024.2.0
- the extension was completely **rewritten in Vue.js 3 with Vite using QUASAR with BEX**
(for [#56](https://github.com/qownnotes/web-companion/issues/56))
(for [#56](https://github.com/qownnotes/web-companion/issues/56))
- also both the Chrome and Firefox extensions are now using manifest version 3

## 22.12.1
Expand Down
44 changes: 24 additions & 20 deletions src/pages/PopupPage.vue
Original file line number Diff line number Diff line change
Expand Up @@ -116,26 +116,30 @@
>
<template v-slot:body="props">
<q-tr :props="props" @click="openUrl(props.row.url)">
<q-td v-if="props.row.name" key="name" :props="props">
<div>
<div class="column-name" tabindex="2" :accesskey="props.rowIndex + 1" @keyup.enter="openUrl(props.row.url)">{{ truncateText( props.row.name, 40 ) }}</div>
<q-tooltip>
<div class="column-name" v-if="props.row.name">{{ props.row.name }}</div>
<div>{{ props.row.url }}</div>
<div class="column-description" v-if="props.row.description">{{ props.row.description }}</div>
</q-tooltip>
</div>
</q-td>
<q-td v-if="props.row.name" key="url" :props="props">
<div>
{{ truncateText( props.row.url, 40 ) }}
</div>
</q-td>
<q-td v-if="props.row.name === ''" colspan="2" key="url" :props="props">
<div>
<a tabindex="2" :href="props.row.url" @click="$event.stopPropagation()" :accesskey="props.rowIndex + 1" target="_blank" :title="props.row.url">{{ truncateText( props.row.url, 80 ) }}</a>
</div>
</q-td>
<template v-if="props.row.name">
<q-td key="name" :props="props">
<div>
<div class="column-name" tabindex="2" :accesskey="props.rowIndex + 1" @keyup.enter="openUrl(props.row.url)">{{ truncateText( props.row.name, 40 ) }}</div>
<q-tooltip>
<div class="column-name" v-if="props.row.name">{{ props.row.name }}</div>
<div>{{ props.row.url }}</div>
<div class="column-description" v-if="props.row.description">{{ props.row.description }}</div>
</q-tooltip>
</div>
</q-td>
<q-td key="url" :props="props">
<div>
{{ truncateText( props.row.url, 40 ) }}
</div>
</q-td>
</template>
<template v-else>
<q-td colspan="2" key="url" :props="props">
<div>
<a tabindex="2" :href="props.row.url" @click="$event.stopPropagation()" :accesskey="props.rowIndex + 1" target="_blank" :title="props.row.url">{{ truncateText( props.row.url, 80 ) }}</a>
</div>
</q-td>
</template>
<q-td key="tags" :props="props">
<div class="column-tags">
<q-badge v-for="tag in props.row.tags" :key="tag" :label="tag" />
Expand Down

0 comments on commit 629be39

Please sign in to comment.