Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ath11k_nss: Fix iface stats showing up as 0
Generic ndo_get_stats64 was removed in kernel > 6.9. This ends up breaking interface stats on NSS builds. ``` phy0-ap0 Link encap:Ethernet HWaddr UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:0 errors:0 dropped:0 overruns:0 frame:0 TX packets:0 errors:0 dropped:841 overruns:0 carrier:0 collisions:0 txqueuelen:1000 RX bytes:0 (0.0 B) TX bytes:0 (0.0 B) phy1-ap0 Link encap:Ethernet HWaddr UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:0 errors:0 dropped:0 overruns:0 frame:0 TX packets:0 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:1000 RX bytes:0 (0.0 B) TX bytes:0 (0.0 B) ``` Until a better workaround is implemented revert the following patch. ``` commit c018411d355518a0b2a304d7543564cdd1b808b6 Author: Breno Leitao <[email protected]> AuthorDate: Fri Jun 7 03:20:44 2024 -0700 Commit: Johannes Berg <[email protected]> CommitDate: Wed Jun 12 13:04:24 2024 +0200 wifi: mac80211: Remove generic .ndo_get_stats64 Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is configured") moved the callback to dev_get_tstats64() to net core, so, unless the driver is doing some custom stats collection, it does not need to set .ndo_get_stats64. Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 function pointer. In this driver specifically, .ndo_get_stats64 basically points to dev_fetch_sw_netstats(). Now it will point to dev_get_tstats64(), which calls netdev_stats_to_stats64() and dev_fetch_sw_netstats(). netdev_stats_to_stats64() seems irrelevant for this driver. ``` Signed-off-by: Sean Khan <[email protected]>
- Loading branch information