Skip to content

Commit

Permalink
d1: define subtarget specifically
Browse files Browse the repository at this point in the history
Historically it's possible to leave the `SUBTARGETS` undefined and
automatically fallback to a "generic" subtarget. This however breaks
various downstream scripts which may have expectations around filenames:

While some targets with an explicit generic subtarget contain `generic`
in the filenames of artifacts, implicit "subtargets" don't.

Right now this breaks the CI[1], possibly also scripts using the ImageBuilders.

Do to the D1 target what's done to other target, explicitly define the
"generic" subtarget.

[1]: https://github.com/openwrt/openwrt/actions/runs/8592821105/job/23548273630

Signed-off-by: Paul Spooren <[email protected]>
  • Loading branch information
aparcar committed Apr 8, 2024
1 parent 0688cf5 commit 3ce1e4c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions target/linux/d1/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ BOARD:=d1
BOARDNAME:=AllWinner D1 RISC-V SoC
FEATURES:=ext4 squashfs
KERNELNAME:=Image dtbs
SUBTARGETS:=generic

KERNEL_PATCHVER:=6.1

Expand Down
1 change: 1 addition & 0 deletions target/linux/d1/generic/target.mk
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
BOARDNAME:=Generic

0 comments on commit 3ce1e4c

Please sign in to comment.