test: Add new acceptance test project #359
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Kupty <[email protected]>
hkupty
force-pushed
the
slf4j-test/initial-impl
branch
from
0b5fed8
to
67a5ab7
Compare
|
I'm relatively happy with this approach. I'd like to know whether we need more cases for Additional suites should be created after this one for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #357
So, I've decided to start simple and go with a basic set of tests, with the intention of iteratively going through some cases and getting to a point where this is actually usable by other slf4j implementations.
I also took the chance to implement it for
slf4j-simpleas means of testing the API.I went on with your suggestion as it seems to be more fitting to the usual java projects and, although
AcceptanceTestdoesn't look like a regular test file I'm quite satisfied with how it looks, so I'm curious for your opinion.I'm keeping this PR as draft for now as I'm of course willing to add more tests and adapt names, project structure and other small details.
Looking forward to hearing your opinion.