Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should_upstream.jl removed since it has been upstreamed in QuantumOpticsBase.jl #34

Merged
merged 6 commits into from
May 31, 2023

Conversation

mabuni1998
Copy link
Collaborator

@mabuni1998 mabuni1998 commented May 31, 2023

Lazy operators are now contagious in QuantumOpticsBase.jl as described in: qojulia/QuantumOpticsBase.jl#86

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #34 (c480f52) into main (2e4d63c) will decrease coverage by 1.85%.
The diff coverage is 68.78%.

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   65.51%   63.67%   -1.85%     
==========================================
  Files          11       10       -1     
  Lines        1595     1503      -92     
==========================================
- Hits         1045      957      -88     
+ Misses        550      546       -4     
Impacted Files Coverage Δ
src/WaveguideQED.jl 100.00% <ø> (ø)
src/plotting.jl 0.00% <0.00%> (-10.53%) ⬇️
src/detection.jl 75.51% <50.00%> (-8.02%) ⬇️
src/CavityWaveguideOperator.jl 60.34% <59.25%> (-7.08%) ⬇️
src/solver.jl 72.72% <70.00%> (+32.72%) ⬆️
src/basis.jl 56.50% <72.72%> (-7.40%) ⬇️
src/WaveguideInteraction.jl 45.90% <75.00%> (-9.84%) ⬇️
src/WaveguideOperator.jl 69.53% <75.90%> (-8.62%) ⬇️
src/precompile.jl 100.00% <100.00%> (+90.38%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mabuni1998 mabuni1998 changed the title should_upstream.jl removed as QuantumOpticsBase.jl now has features should_upstream.jl removed since it has been upstreamed in QuantumOpticsBase.jl May 31, 2023
@mabuni1998 mabuni1998 merged commit c148465 into main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant