Load keymaps from subdirectories #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noroadsleft
force-pushed
the
feature/subfolders
branch
from
0d16ea6
to
d2a2688
Compare
|
I think this is just too much. I would go with something simpler. Just take the first character of every existing path and make that a folder. [0-9a-z] so 38 folders and just drop them in alphabetically into those folders. This is fast and simple string operation to figure out where to search. |
noroadsleft
force-pushed
the
feature/subfolders
branch
from
d2a2688
to
2cbcea9
Compare
yanfali
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stripped-down version of #591; it doesn't do any of the layout macro business. Seven hundred keymap files in one folder is getting to be a real PITA to maintain.