Redesign #1060
Draft
Redesign #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanfali
force-pushed
the
redesign
branch
3 times, most recently
from
77765b5
to
f3048c3
Compare
- layouts predefined based on N A X redesign
- layouts predefined based on N A X redesign
- I may need to rip the whole infrastructure down as the existing style sheet is currently dominant - overall the slots and templates seem to work, but there are issues where the child components are being used correctly for sizing. It could be their positioning.
- setup overall page layout - try out approaches for separating layout from components
- emit uploadJSON event - implement import URL toggle
- navigator.platform has been deprecated. Shim it to use the new API if it is available, otherwise use the fallback.
- sadly because we are on vue2 I can't use the composition API for this because the i18n v8 API uses a global on this instance - this uses a computed value to display the message, and then we observe changes in the index which triggers a re-render - forward and backward controls are implemented as per mocks but the iconography is from FA
it's a really big library, but I do like the features it offers so it may be worth it if we can lazy load it. We'll only use a small amount of it's functionality, but it does render links quite well.
Until I get the console stuff working the about is just attached to the end. I may make it disappear if the console is open.
* added colors to windi Co-authored-by: Yan-Fa Li <[email protected]>
- needs a better solution but this is a workaround for now Transition max-height instead of height
* changed close to a button * Update ImportControl.vue * Update ImportControl.vue Fix formatting Co-authored-by: Yan-Fa Li <[email protected]>
- integration into terminal - integrate into layer picker placeholder
- circles, spacing
- combining CSS Modules with Windi actually seems to work
- it's a bit ugly but it does work as opposed to scoped which did not
work with css classes using the map style of class activation.
- fake data to show circles for active layer
- update call sites for old store - Clean up old watcher state - Await view readme changes to avoid races in updates - Append not defer since we are waiting for viewReadme - Make scrolling more consistent
- port store code from vuex to pinia - fix up all references to store to point to pinia keycodes store - delete vuex keycodes implementation - delete vuex status implementation - lookup keycodes is everywhere :)
- move getters and state to pinia - move mutations and actions to pinia - re-write mappers or use stores reference - Remove tester vuex store
- probably on VM it takes to long to render (> 5 secs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft Redesign Branch for work in progress
Description