Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook 을 호출하는 serverUri 부분 다른 resolve 와 동일하게 config 를 가져오도록 수정 #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Webhook 을 호출하는 serverUri 부분 다른 resolve 와 동일하게 config 를 가져오도록 수정 #2

wants to merge 1 commit into from

Conversation

victor-jo
Copy link

AS-IS

  • Webhook 호출하는 serverUri 를 가져올 때 Scope.Config 객체에서는 확인하지 않고 넘어간다

TO-BE

  • Webhook 호출하는 serverUri 를 가져올 때 Scope.Config 객체에서도 확인하고 넘어간다

@victor-jo victor-jo self-assigned this Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moowoonsunghoon moowoonsunghoon Awaiting requested review from moowoonsunghoon

@GreatLaboratory GreatLaboratory Awaiting requested review from GreatLaboratory

Assignees

@victor-jo victor-jo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@victor-jo