GitHub #111 enable unicode headers #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- drop duplicate function and import - fix whitespace - split long lines
- Can't use an arbitrary string, validation requires a UUID
ThrawnCA
force-pushed
the
github-111-unicode-headers
branch
from
fd9c758
to
a8c3f6a
Compare
- Values are not subject to floating-point errors as the original test expected
duttonw
approved these changes
Oct 17, 2024
I'm not sure whether the current approach actually works, or whether the original author tested it. Might need to come back to this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening new PR to fix merge conflict in #111.