[QHC-700] Add qibo routing #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…connected-to-a-bus
…o-a-bus' of github.com:qilimanjaro-tech/qililab into qhc-777-add-channel_ids-for-all-instruments-connected-to-a-bus
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #821 +/- ##
==========================================
+ Coverage 96.51% 96.61% +0.10%
==========================================
Files 218 221 +3
Lines 7432 7652 +220
==========================================
+ Hits 7173 7393 +220
Misses 259 259
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Base automatically changed from
qhc-777-add-channel_ids-for-all-instruments-connected-to-a-bus
to
main
October 30, 2024 11:17
|
I am starting reviewing now, first thing I noticed is that changelog entry is missing! Please write a detailed one, with an example on how to use the routing. |
You are soo right, my bad! Adding it right now 👍 |
|
@fedonman changelog added! 🔥 |
fedonman
reviewed
Nov 7, 2024
* Improve transpiler * Update circuit_transpiler.py * Add pairs of hermitian gate cancellation * Making the transpiler more modular * Make transpiler more modular * Update circuit_to_pulses.py * Update circuit_transpiler.py * Update circuit_to_pulses.py * Solve problem with Drag initialization, and tests * Solve tests * Solving and testing circuit optimizer * Solving unit tests * Adding unit test * Solve.unit test * Update changelog-dev.md * Update changelog-dev.md * Improve typings and docstrings * Take optimize parameter in cascade up, to the user calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Qibo routing to
qililab, both for:PROBLEMS TO SOLVE:
_iterate_routing)Missing:
More improvements on the transpiler structure, added by: #823