Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QHC-777] Major refactor to simplify things #820

Merged

Conversation

fedonman
Copy link
Collaborator

@fedonman fedonman commented Oct 15, 2024

Major reorganization of the library structure and runcard functionality. Key updates include:

  • Removed obsolete instruments, such as VNAs.
  • Removed the drivers module.
  • Simplified the Qblox sequencer class hierarchy into two main classes: QbloxSequencer and QbloxADCSequencer.
  • Removed SystemController and ReadoutSystemController; buses now interface directly with instruments.
  • Introduced a new channels attribute to the Bus class, allowing specification of channels for each associated instrument.
  • Removed the Chip class and its related runcard settings.
  • Eliminated outdated settings, such as instrument firmware.
  • Refactored runcard settings into a modular structure with four distinct groups:
    • instruments and instrument_controllers for lab instrument setup.
    • buses for grouping instrument channels.
    • digital for digital compilation settings (e.g., Qibo circuits).
    • analog for analog compilation settings (e.g., annealing programs).

Copy link

linear bot commented Oct 15, 2024

@fedonman fedonman marked this pull request as ready for review October 22, 2024 20:02
Copy link

Hello. You may have forgotten to update the changelog!
Please edit changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.51%. Comparing base (01c70ec) to head (39c0f92).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #820      +/-   ##
==========================================
+ Coverage   96.19%   96.51%   +0.31%     
==========================================
  Files         278      218      -60     
  Lines        9518     7425    -2093     
==========================================
- Hits         9156     7166    -1990     
+ Misses        362      259     -103     
Flag Coverage Δ
unittests 96.51% <100.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/codecov.yml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
Copy link
Contributor

@jordivallsq jordivallsq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revised the code and tested the creation of platform using the new runcard. Great job!!

@fedonman fedonman merged commit fe0e669 into main Oct 30, 2024
6 checks passed
@fedonman fedonman deleted the qhc-777-add-channel_ids-for-all-instruments-connected-to-a-bus branch October 30, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants