Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QHC-554] Implement compilation of waveform variables in Qblox #742

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

fedonman
Copy link
Collaborator

No description provided.

Copy link

linear bot commented Jun 25, 2024

@fedonman fedonman marked this pull request as ready for review July 10, 2024 10:31
Copy link

Hello. You may have forgotten to update the changelog!
Please edit changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 71.60000% with 71 lines in your changes missing coverage. Please review.

Project coverage is 94.25%. Comparing base (75b5085) to head (5223cb3).

Files Patch % Lines
src/qililab/qprogram/variable.py 52.70% 35 Missing ⚠️
src/qililab/qprogram/qblox_compiler.py 78.80% 32 Missing ⚠️
src/qililab/qprogram/operations/measure.py 25.00% 3 Missing ⚠️
src/qililab/waveforms/waveform.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   94.95%   94.25%   -0.70%     
==========================================
  Files         263      263              
  Lines        8589     8780     +191     
==========================================
+ Hits         8156     8276     +120     
- Misses        433      504      +71     
Flag Coverage Δ
unittests 94.25% <71.60%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant