Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ORIGINALY
In our DataFrames, perviously we had a normal index, and then columns to represent the different index before concatenating df's, such as:
loop_indexes
results_index
acquisition_index
bin_index
which were just copies of the previous indices, and the name after concatenating should now be read as:
acquisition_index
= index this sub-df had when we were at acquisition df's level (before concatenating at acquisition level)NOW
But after this PR, we will also have columns representing in which of those concatenated objects they were:
circuit_index
qubit_index
bins_index
So now for each level, we have two types of indices, ones that tells you in which
df
of thelist[df]
they were [new added indices], and another one that tells you the previous indices they had inside those df (before concatenation) [old indices].Notice that
bins_index
is in both, this is because it is the lowest level we can go, if we could go even lower, this would be split into two indices too.REDUNDANCY
And actually now, with these new columns there is redundancy in the information of the dataframe, since:
df['qubit_number']=(df['acquisition_index'] - df['bin_index']) / num_bin)
df['circuit_number']=(df['acquisition_index'] - df['bin_index']) / (num_qubits*num_bin)
But I still consider worth it for small df, since it is way more visual now. (For larger DF, we should consider reducing this redundancy)
LINKED PRs/Issues
PR on dummy_pulsar
https://github.com/qilimanjaro-tech/qililab-tools/pull/13
Ana's Issues
#402
#403
TO DO:
acquisition_index
result_index
to_dataframe()
method (You removedresult_index
)loop_indexs
work correctlydata.py
, to change and make the test more complex(you need to see how to pass
threshold
parameters intobinary_classification
in qblox library)sequence_index
&software_avg_index
columnstest_qblox_result
implement/delete commented code after understanding it