Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - v1.3.1 #201

Merged
merged 24 commits into from
Sep 6, 2024
Merged

Release - v1.3.1 #201

merged 24 commits into from
Sep 6, 2024

Conversation

qgustavor
Copy link
Owner

@qgustavor qgustavor commented Jun 29, 2024

@qgustavor
Copy link
Owner Author

I guess we can wait to #205 to be fixed before releasing v1.3.1, right?

About the error in the Deno test integration, it was not an error in the library itself but in Deno somehow:

Snippet of the error log
[rest of the log skipped]
Tests will use this directory: /tmp/megajs-tests-1940-A3ZVCxjTEaB0

============================================================
Deno has panicked. This is a bug in Deno. Please report this
at https://github.com/denoland/deno/issues/new.
If you can reliably reproduce this panic, include the
reproduction steps and re-run with the RUST_BACKTRACE=1 env
var set and include the backtrace in your report.

Platform: linux x86_64
Version: 1.46.2
Args: ["deno", "test", "--allow-env=MEGA_MOCK_URL", "--allow-net=127.0.0.1:44079/"]

thread 'main' panicked at cli/args/flags.rs:5078:60:
called `Result::unwrap()` on an `Err` value: ErrorInner { kind: InvalidValue, context: FlatMap { keys: [], values: [] }, message: Some(Raw("invalid port in '127.0.0.1:44079/': '44079/'")), source: None, help_flag: None, styles: Styles { header: Style { fg: None, bg: None, underline: None, effects: Effects() }, error: Style { fg: None, bg: None, underline: None, effects: Effects() }, usage: Style { fg: None, bg: None, underline: None, effects: Effects() }, literal: Style { fg: None, bg: None, underline: None, effects: Effects() }, placeholder: Style { fg: None, bg: None, underline: None, effects: Effects() }, valid: Style { fg: None, bg: None, underline: None, effects: Effects() }, invalid: Style { fg: None, bg: None, underline: None, effects: Effects() } }, color_when: Never, color_help_when: Never, backtrace: None }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Deno tests exited with code 1

@xmok
Copy link
Contributor

xmok commented Sep 4, 2024

Fantastic troubleshooting in the aforementioned Issue. In the meantime I'll make another PR soon with some more missing TS types. I found a few more so I'll lump them into manageable PRs rather than one-liners. Hopefully that will be in time for the new release, as well 😄.

@qgustavor
Copy link
Owner Author

That's fine, I'm really grateful you are helping in this project! 😄

@qgustavor
Copy link
Owner Author

I need to fix the Deno tests: from the error log that's just something wrong in the arguments to "deno test" in the test runner which includes a forward slash with the port number.

--allow-net should not include a trailing slash
I always forget about that, so is better to put it in the readme.
Add a note about updating TypeScript types
It was calling .find instead of calling .filter to recurse directories
Handle `ssl` in API's pull request so Storage works in browsers
Use globalThis.isSecureContext
@qgustavor
Copy link
Owner Author

This PR will be pushed after #211 gets voted by the community either in the PR itself or here. If no one votes in 72 hours I will just push it since #210 is a critical bug for me.

@qgustavor qgustavor merged commit c645885 into main Sep 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants