Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on latest cppcheck #24

Merged
merged 4 commits into from
Dec 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/facebookexternalinterceptordemo/fbdemo.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class FBDemo : public QObject
Q_OBJECT

public:
explicit FBDemo(QObject *parent = 0);
explicit FBDemo(QObject *parent = nullptr);

signals:
void extraTokensReady(const QVariantMap &extraTokens);
Expand Down
2 changes: 1 addition & 1 deletion examples/sialis/tweetmodel.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class TweetModel : public QAbstractListModel {
RoleText = Qt::UserRole + 1,
};

TweetModel(QObject *parent = 0);
TweetModel(QObject *parent = nullptr);

/// Clear all tweets
void clearTweets();
Expand Down
2 changes: 1 addition & 1 deletion examples/sialis/twitterapi.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class TwitterApi: public QObject {
O1Twitter *authenticator() const;
void setAuthenticator(O1Twitter *v) ;

explicit TwitterApi(QObject *parent = 0);
explicit TwitterApi(QObject *parent = nullptr);
virtual ~TwitterApi();

public slots:
Expand Down
1 change: 1 addition & 0 deletions scripts/cppcheck.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ cppcheck --inline-suppr \
-DQ_ENUMS = \
-DQ_ENUM = \
-DQ_DECLARE_OPERATORS_FOR_FLAGS = \
-DQ_SLOTS = \
-Dforeach = \
-j $(nproc) \
${SCRIPT_DIR}/../src \
Expand Down
4 changes: 2 additions & 2 deletions src/o1smugmug.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ static const char *accessToString(O1SmugMug::Access access) {
const std::size_t stringsSize = sizeof(strings) / sizeof(strings[0]);
Q_ASSERT(access >= 0 && static_cast<std::size_t>(access) < stringsSize
&& "Unsupported SmugMug authorization access!");
Q_UNUSED(stringsSize)
(void)stringsSize;

return strings[access];
}
Expand All @@ -28,7 +28,7 @@ static const char *permissionsToString(O1SmugMug::Permissions permissions) {
const std::size_t stringsSize = sizeof(strings) / sizeof(strings[0]);
Q_ASSERT(permissions >= 0 && static_cast<std::size_t>(permissions) < stringsSize
&& "Unsupported SmugMug authorization permissions!");
Q_UNUSED(stringsSize)
(void)stringsSize;

return strings[permissions];
}
Expand Down
2 changes: 1 addition & 1 deletion src/o1upwork.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ class O1Upwork: public O1 {
Q_OBJECT

public:
explicit O1Upwork(QObject *parent = 0) : O1(parent) {
explicit O1Upwork(QObject *parent = nullptr) : O1(parent) {
setRequestTokenUrl(QUrl("https://www.upwork.com/api/auth/v1/oauth/token/request"));
setAuthorizeUrl(QUrl("https://www.upwork.com/services/api/auth"));
setAccessTokenUrl(QUrl("https://www.upwork.com/api/auth/v1/oauth/token/access"));
Expand Down
2 changes: 1 addition & 1 deletion src/o2uber.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class O0_EXPORT O2Uber: public O2{
Q_OBJECT

public:
O2Uber(QObject *parent = 0);
explicit O2Uber(QObject *parent = nullptr);

public Q_SLOTS:
void onVerificationReceived(QMap<QString, QString>) override;
Expand Down
Loading