PKCE fixes #22
Merged
PKCE fixes #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Disclaimer: I am not an OAuth expert) PKCE is an *extension* to Authorization-Code-Flow, so the response_type should still be `code`.
(Disclaimer: I am not an OAuth expert) PKCE does not preclude transmitting `client_secret` - at least Google OAuth does *not* work without it and explicity complains about it missing. This is also consistent with their documentation ([1]). (As far as I understand, PKCE is really orthogonal to client authenticiation, it is only meant to protect the Authorization Code.) This is also consistent with my understanding of RFC 6749, "4.1.3. Access Token Request" ([2], emphasis added by me): > If the client type is confidential *OR* the client was issued client > credentials (or assigned other authentication requirements), the > client MUST authenticate with the authorization server as described > in Section 3.2.1. [1] https://developers.google.com/identity/protocols/oauth2/native-app, "Step 5: Exchange authorization code for refresh and access tokens" [2] https://www.rfc-editor.org/rfc/rfc6749#section-4.1.3
elpaso
approved these changes
Dec 19, 2024
|
Thanks @elpaso! |
|
Note also that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes required to make PKCE work with Google.