-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend update #5
Conversation
That is looking fantastic @Xpirix ! |
@Xpirix using Google Chrome 129.0.6668.70 on Windows 10 |
Thanks for the review @agiudiceandrea. Managing the table is a bit tricky as we have large left and right margins on the new branding. Indeed, the table becomes scrollable horizontally on a smaller screen. What do you think about keeping the grid view only? Or we can also hide some columns on a smaller screen (depending on the priority of the columns) |
I've missed the horizontal scroll bar... Having the horizontal scroll bar both at the bottom and at the top would be useful.
I think the table view is useful. I've also noticed that the choice between grid and table view doesn't stick: if you choose the table view and then click on the "Next" button, then the list is shown again as a grid. The same occurs if you go from e.g. the "All plugins" list to the "New plugins" list.
I think, on the contrary, that there are missing columns, like the "Created on" column and the latest version number. It seems to me the "Stable" list should not be in "Top", but probably in "Category". I would also suggest to add a simple description on each list page on how the list is generated / sorted (e.g. the "Popular" list name is not self explanatory). |
I agree, I've also had that idea but didn't implement it yet.
I think it will impact the general look of plugins' website and make it a bit different from the main website. But I think it would be okay to reduce them for some inches. I will try and see how it will look. I will also add the missing columns.
Yes, the view choice is not memorised yet. I will probably use the local storage for it.
Those are well noted, thank you. I will also fix them. Many thanks for the reviews. Your feedback is greatly appreciated. Please feel free to let me know if you notice anything else that needs attention. |
Looking fantastic! 🤩 Table width+1 for making the table wider. This page is really about information retrieval, less about marketing, so even if it does not look as nice, it's worth it. :) Grid in tall/narrow responsive modeWhen the grid view is shown in a narrow window, the date and stars are unnecessarily in two separate lines. It would save a good bit of space to put them into a single line. SpeedClicking to the next page is really slow. E. g. https://staging.plugins.qgis.org/plugins/?page=6&sort=average_vote&order=desc takes 5 seconds. |
Thank you very much for the feedback @kannes. I will take a look and try to fix each point. |
Thanks for implementing all the suggestions! |
Homepage:
Plugins List: