Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize the experimental flag in the metadata #494

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Dec 3, 2024

Fix for #477

In the Upload new plugins/version form, the Experimental checkbox says: Check this box if this version is experimental, leave unchecked if it's stable. Please note that this field might be overridden by metadata (if present). So it would make sense to prioritise the experimental attribute in the metadata and get the value from the checkbox if it's not set.

This change removes the extra validation that compares both values and allows the expected workflow.

@Gustry
Copy link
Contributor

Gustry commented Dec 3, 2024

Side question, shouldn't we have a same behavior for the server checkbox ? Ref #487
It would make sense, if it's not already the case ?

@Xpirix
Copy link
Collaborator Author

Xpirix commented Dec 4, 2024

@Gustry ( also replying to #487 (comment))

The primary distinction is that the server checkbox pertains to the plugin itself, while the experimental checkbox applies only to a specific version. Currently, the server checkbox takes precedence and can be activated either manually or by setting the server flag in the metadata of the initial plugin.

But yes, it would make sense to prioritise the value of the server field from the metadata.txt file whenever it is present. If we adopt that approach, a new version of the plugin will override the general information and settings, as we currently do for fields like Description, About, and others.

@Gustry
Copy link
Contributor

Gustry commented Dec 4, 2024

Thanks for these clarifications. You can let it like this for now. If was mainly to keep notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants