Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Layer Definition File and 3D Model to the resource API #388

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Apr 23, 2024

This is a proposed change for #280

Changes summary

  • Return Layer Definition and Wavefront (3D Model) in the resource API
  • Update unit test

image

@ismailsunni
Copy link

So, Wafefront is the 3D model? May I know why is it called like that? Otherwise, it looks good for me

@Xpirix
Copy link
Collaborator Author

Xpirix commented Apr 23, 2024

I think it refers to the pip package the app used to manage 3D models which is called PyWavefront. It's related to #182.

@ismailsunni
Copy link

@Xpirix perhaps, it's better to have different terminology for the resource type since it's not self explanatory. It is also more on the technical term, not the context. See similar comment regarding this #202 (comment). I guess 3DModel is clearer.

@Xpirix
Copy link
Collaborator Author

Xpirix commented Apr 24, 2024

Yes, that makes more sense. I've changed Wavefront to 3DModel for the resource API for now. Also, I will create an issue to replace all Wavefront occurrences in the code with 3DModel.

image

@ismailsunni
Copy link

Thanks @Xpirix !

@dimasciput dimasciput merged commit 207457e into qgis:master Jun 19, 2024
2 checks passed
@ismailsunni
Copy link

thanks lord @dimasciput

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants