Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making license file not required for now #314

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Nov 27, 2023

According to the discussion and suggestions at https://lists.osgeo.org/pipermail/qgis-developer/2023-November/066275.html, this PR is a fix for the breaking change on the plugin upload/update workflow. This is about the following issue:

For now, a license file should be recommended. When missing, it should generate a non-blocking warning either for new or existing plugins.

Please find below a screenshot of the warning when uploading or updating a plugin package that doesn't contain a license file:
Screenshot 2023-11-27 at 3 51 39 PM

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (08f01b4) 32.52% compared to head (24b468c) 32.51%.

Files Patch % Lines
qgis-app/plugins/views.py 0.00% 3 Missing ⚠️
qgis-app/plugins/tests/test_validator.py 33.33% 2 Missing ⚠️
qgis-app/plugins/forms.py 0.00% 1 Missing ⚠️
qgis-app/plugins/validator.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
- Coverage   32.52%   32.51%   -0.02%     
==========================================
  Files          71       71              
  Lines        4218     4217       -1     
==========================================
- Hits         1372     1371       -1     
  Misses       2846     2846              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xpirix
Copy link
Collaborator Author

Xpirix commented Nov 28, 2023

Please find below a screenshot of the updated warning according to this comment.

Screenshot 2023-11-28 at 8 43 58 AM

@Xpirix Xpirix requested a review from dimasciput November 28, 2023 06:37
@dimasciput dimasciput merged commit 0a5d8a9 into qgis:master Nov 30, 2023
2 checks passed
@Xpirix Xpirix deleted the license_recommended branch January 2, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants