Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license requirement #311

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Nov 23, 2023

Please find below the issue related to the current PR:

@Xpirix Xpirix requested a review from dimasciput November 23, 2023 14:48
@dimasciput dimasciput merged commit 08f01b4 into qgis:master Nov 24, 2023
2 checks passed
@Guts
Copy link
Contributor

Guts commented Nov 24, 2023

@Xpirix sorry bu can you give more details about what this PR does?

@Xpirix
Copy link
Collaborator Author

Xpirix commented Nov 24, 2023

Dear @Guts ,

Many thanks for your feedback.

In this PR, The license file is only required for new plugins. For existing plugin updates, it generates just a warning (but doesn't fail) when the license file is missing.
However, I'm not sure if we should also just generate a warning for new plugin uploads for now. If so, I will also fix the new plugin upload.

Kind regards.

@Guts
Copy link
Contributor

Guts commented Nov 24, 2023

Thanks @Xpirix for the details here.

However, I'm not sure if we should also just generate a warning for new plugin uploads for now. If so, I will also fix the new plugin upload.

Again, my "debate" is not about forcing my opinion but to discuss before deploying breaking changes. Without discussion, how is possible to apply this, straightforward to the production platform? I can't find a good answer, so I think it's preferable to only display a warning for a time, communicate to the end-users (here plugins developer) through dev list and documentation and then push the change.

And again, your work here, on this project, is such a great thing! I'm not questioning the technical work but the necessary collaborative mood of the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants