Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to fix none in search results #304

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Nov 13, 2023

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2057611) 37.76% compared to head (ddeee8f) 34.56%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
- Coverage   37.76%   34.56%   -3.21%     
==========================================
  Files          96       65      -31     
  Lines        3948     3744     -204     
==========================================
- Hits         1491     1294     -197     
+ Misses       2457     2450       -7     

see 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agiudiceandrea
Copy link
Contributor

Hi @Xpirix, it looks like there is still "none" in search results
https://plugins.qgis.org/search/?q=tool

image

@dimasciput dimasciput merged commit d0195c1 into qgis:master Nov 20, 2023
2 checks passed
@Xpirix
Copy link
Collaborator Author

Xpirix commented Nov 20, 2023

Hello @agiudiceandrea, thank you for the feedback. However, we are in the process of planning the deployement. This will be fixed once the command in the current PR is done server-side.

@Xpirix
Copy link
Collaborator Author

Xpirix commented Nov 22, 2023

Dear @agiudiceandrea , We have done running the command. This issue is fixed now.

@Xpirix Xpirix deleted the fix_none_in_search_results branch January 2, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants