Make LICENSE file as required in plugin package (#309)

* Make LICENSE file as required in plugin package

* Update qgis-app/plugins/validator.py

---------

Co-authored-by: Dimas Ciputra <[email protected]>

qgis-app/plugins/tests/test_validator.py

@@ -193,3 +193,28 @@ def test_zipfile_with_gitignore(self, mock_namelist):
             exception.message,
             "For security reasons, zip file cannot contain '.git' directory",
         )
+
+
+class TestLicenseValidator(TestCase):
+    """Test if zipfile contains LICENSE file """    
+
+    def setUp(self) -> None:
+        plugin_without_license = os.path.join(TESTFILE_DIR, "plugin_without_license.zip_")
+        self.invalid_plugin = open(plugin_without_license, "rb")
+
+    def tearDown(self):
+        self.invalid_plugin.close()
+
+    def test_zipfile_without_license(self):
+        self.assertRaises(
+            ValidationError,
+            validator,
+            InMemoryUploadedFile(
+                self.invalid_plugin,
+                field_name="tempfile",
+                name="testfile.zip",
+                content_type="application/zip",
+                size=39889,
+                charset="utf8",
+            ),
+        )

qgis-app/plugins/validator.py

@@ -237,6 +237,11 @@ def validator(package):
     if initname not in namelist:
         raise ValidationError(_("Cannot find __init__.py in plugin package."))
 
+    # Checks for LICENCE file precense
+    licensename = package_name + "/LICENSE"
+    if licensename not in namelist:
+        raise ValidationError(_("Cannot find LICENSE in plugin package."))
+
     # Checks metadata
     metadata = []
     # First parse metadata.txt