Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow changing the CONTAINER_REGISTRY for continuous benchmarks #105

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix: Allow changing the CONTAINER_REGISTRY for continuous benchmarks #105

merged 1 commit into from
Mar 11, 2024

Conversation

KShivendu
Copy link
Member

@KShivendu KShivendu commented Mar 11, 2024 •
edited
Loading

A small but critical bug.

dev container benchmark wasn't using dev container benchmark. We added CONTAINER_REGISTRY to engine/servers/qdrant-single-node but not qdrant-continuous.

@KShivendu KShivendu requested a review from generall March 11, 2024 09:03
@KShivendu KShivendu merged commit 20ec952 into master Mar 11, 2024
5 checks passed
@KShivendu KShivendu deleted the fix/qdrant-continuous-benchmark branch April 17, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@generall generall generall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KShivendu @generall