Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: incompatible versions warning on init #858

Closed
wants to merge 4 commits into from

Conversation

tellet-q
Copy link
Contributor

Introduce an optional boolean arg check_versions that checks versions during client init and generates a warning if versions are not compatible. Compatible versions are the ones that differ by one, i.e client version 1.6.x is compatible with server versions 1.5.x and 1.7.x but not 1.4.x or 1.8.x.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@tellet-q tellet-q requested review from generall and joein November 26, 2024 10:15
Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit b6d8dd9
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/67459fadf7ce880008ebdc25
😎 Deploy Preview https://deploy-preview-858--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tellet-q tellet-q closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant