Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User warnings large upload #852

Merged
merged 10 commits into from
Dec 5, 2024
Merged

User warnings large upload #852

merged 10 commits into from
Dec 5, 2024

Conversation

hh-space-invader
Copy link
Contributor

@hh-space-invader hh-space-invader commented Nov 15, 2024

Add user warnings if uploading or loading collection with more than 20K points in local mode.
I've refactored the way we do DeprecationWarning as we also want to add UserWarning to be shown once by adding show_warning and show_warning_once and then specify the category of the warning needed to be shown once.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit 2bded2f
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/67519426e888480008269077
😎 Deploy Preview https://deploy-preview-852--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

qdrant_client/common/deprecations.py Outdated Show resolved Hide resolved
qdrant_client/local/local_collection.py Outdated Show resolved Hide resolved
qdrant_client/local/local_collection.py Outdated Show resolved Hide resolved
qdrant_client/local/local_collection.py Outdated Show resolved Hide resolved
@hh-space-invader hh-space-invader force-pushed the user-warnings-large-upload branch from bbaf993 to b2bb898 Compare November 19, 2024 11:06
qdrant_client/common/warnings.py Outdated Show resolved Hide resolved
qdrant_client/common/client_warnings.py Outdated Show resolved Hide resolved
qdrant_client/local/async_qdrant_local.py Outdated Show resolved Hide resolved
qdrant_client/local/local_collection.py Outdated Show resolved Hide resolved
refactor: Refactored user warnings in local mode when large upload
@joein joein merged commit 88543cb into dev Dec 5, 2024
9 of 14 checks passed
@hh-space-invader hh-space-invader deleted the user-warnings-large-upload branch December 16, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants