Compaction for fragmented pages #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase on master to get CI 🔥 |
agourlay
reviewed
Sep 26, 2024
src/payload_storage.rs
Outdated
| // This is a loop because we might need to create more pages if the current new page is full | ||
| 'new_page: loop { | ||
| // create new page | ||
| let new_page_id = self.create_new_page(size_hint); |
There was a problem hiding this comment.
I wonder if we should create this page as a tempfile and then move it at the end of compaction.
This way there is no left over if compaction is interrupted.
agourlay
reviewed
Sep 26, 2024
| } | ||
|
|
||
| /// Sums the amount of unused space in between the data. | ||
| pub fn fragmented_space(&self) -> usize { |
There was a problem hiding this comment.
Can you maybe write a simple test for this one?
Write a few values and then delete one and check that fragmentation increases.
There was a problem hiding this comment.
Ah yes, I was forgetting about this one
agourlay
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a while, we expect that having enough updates will create unused regions in between the data for the values, which will be wasted space.
With these changes we add the ability to trigger a compaction. It: