Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add k8sDistribution to status, storage to QdrantConfiguration #24

Closed
wants to merge 7 commits into from
Closed

Add k8sDistribution to status, storage to QdrantConfiguration #24

wants to merge 7 commits into from
+163 −0

Conversation

Charmelionag
Copy link
Contributor

@Charmelionag Charmelionag commented Oct 3, 2024 •
edited
Loading

No description provided.

@Charmelionag Charmelionag requested a review from a team as a code owner October 3, 2024 14:00
@Charmelionag Charmelionag changed the title Update CRD with storage config Add k8sDistribution to status, storage to QdrantConfiguration Oct 3, 2024
Robert-Stam
Robert-Stam approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@Robert-Stam Robert-Stam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally would have created 2 PRs to make the intent of the PR clear.
Besides this LGTM (no need to split for now).

Robert-Stam
Robert-Stam approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@Robert-Stam Robert-Stam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robert-Stam Robert-Stam Robert-Stam approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Charmelionag @Robert-Stam