Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python version and add pre-commit dependency #93

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

NirantK
Copy link
Contributor

@NirantK NirantK commented Jan 16, 2024

No description provided.

@NirantK NirantK requested a review from joein January 16, 2024 09:44
@Anush008
Copy link
Member

@NirantK, why not pin the Python version for pre-commit instead?

@NirantK
Copy link
Contributor Author

NirantK commented Jan 16, 2024

This keeps the dependencies simpler? Unless your case is that we should support Python v3.8?

@Anush008
Copy link
Member

Just a thought. Nothing blocking.

@NirantK NirantK merged commit 3b32619 into main Jan 16, 2024
12 checks passed
@NirantK NirantK deleted the add-missing-dependencies branch January 16, 2024 14:00
@NirantK NirantK restored the add-missing-dependencies branch January 16, 2024 14:00
@NirantK NirantK deleted the add-missing-dependencies branch January 16, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants