review suggestions #398
Merged
review suggestions #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joein
added a commit
that referenced
this pull request
Nov 13, 2024
joein
added a commit
that referenced
this pull request
Nov 13, 2024
joein
added a commit
that referenced
this pull request
Nov 13, 2024
* fix: Fix return of onnx_embed * fix: Fix type hint of start method in worker class * fix: Fix not passing kwargs in _preprocess_onnx_input and tokenize as base class * fix: Fix not passing kwargs in _preprocess_onnx_input as base class * fix: change tokenize in simpleTokenizer to classmethod * chore: Changed query argument to Iterable to match base class * chore: changed mask token id and pad token id to be int * review suggestions (#398) --------- Co-authored-by: George <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.