Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(draft) colpali WIP #394
base: main
Are you sure you want to change the base?
(draft) colpali WIP #394
Changes from 9 commits
0583425
f63f77c
c4bd2c0
ee62c69
3c36c28
34f557c
9274c7d
d4f4e5a
7ca807e
317ccec
d581de9
e43f680
423bb28
dcae3ab
62a065e
68ce437
c040120
367178b
1fff39b
667eee1
a9bddf3
e747c34
0ff8f49
274e0d7
054873a
3684462
4d856c6
b6a51c0
b9eebef
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use only text part of the model here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not really separated in our quantization. We could re-quantize it and separate, but I can not say it will have original behaviour. It could, but I'm not sure 100%
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which image model is used?
How much does it weight?
Does it make sense to split the models or the difference is negligible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gemma 2B