Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify imports: #110 #113

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Simplify imports: #110 #113

merged 5 commits into from
Feb 7, 2024

Conversation

Okabe-Rintarou-0
Copy link
Contributor

Add some imports in init.py to simplify import.

KShivendu
KShivendu reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@KShivendu KShivendu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I think it's a valid suggestion.

@NirantK wdyt?

fastembed/__init__.py Outdated Show resolved Hide resolved
@Okabe-Rintarou-0 @KShivendu
Update fastembed/__init__.py
d045316 
Co-authored-by: Kumar Shivendu <[email protected]>
@joein
Copy link
Member

joein commented Feb 7, 2024

It’s not yet there, only TextEmbedding should be added, the others are outdated

@joein
Copy link
Member

joein commented Feb 7, 2024

embedding.py is kept only for backward compatibility, I would prefer to have import from a proper path because we may delete embedding.py in future releases

thanks for the patience

@NirantK NirantK merged commit 4696818 into qdrant:main Feb 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KShivendu KShivendu KShivendu left review comments

@NirantK NirantK NirantK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Okabe-Rintarou-0 @joein @NirantK @KShivendu