Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Domeneshop #810

Merged
merged 9 commits into from
Oct 9, 2024
Merged

Support for Domeneshop #810

merged 9 commits into from
Oct 9, 2024

Conversation

jobrajac
Copy link
Contributor

@jobrajac jobrajac commented Sep 9, 2024

Added support for Domeneshop, a popular Norwegian DNS provider.
Tested and works:)

https://domene.shop/
https://api.domeneshop.no/docs/

Copy link
Owner

@qdm12 qdm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

  1. Is there an API Route to create records if they don't exist?
  2. Does this code work with ipv6 (at least according to their documentation)
  3. Wildcards are not supported correct?

Thanks!

docs/domeneshop.md Outdated Show resolved Hide resolved
internal/provider/providers/domeneshop/provider.go Outdated Show resolved Hide resolved
internal/provider/providers/domeneshop/provider.go Outdated Show resolved Hide resolved
@jobrajac
Copy link
Contributor Author

Nice thanks!

1. Is there an API Route to create records if they don't exist?

2. Does this code work with ipv6 (at least according to their documentation)

3. Wildcards are not supported correct?

Thanks!

  1. Yes, there is, but it is not something I have tested or have much use for personally. Is that a requirement for you to merge the branch or can that perhaps stay on the todo-list for this provider? As far I can see that option is not present for most of the other providers.

  2. Yes. According to their docs you can set ipv4 or ipv6 using the same url param 'myip'.

  3. I could not find any information on wildcards in their docs so I assumed it to be not supported. I did not test it though.

Thank you for the great repo and quick repsponse!

@jobrajac jobrajac requested a review from qdm12 September 12, 2024 09:43
@qdm12
Copy link
Owner

qdm12 commented Sep 12, 2024

Thanks for the quick response!

  1. Not totally a requirement, but it's a work in progress with Feature request: Create record if it does not exist #129 to check all providers for it. If the domain record doesn't exist, what error do they return? Ideally we would act on a "record does not exist" error (i. e. 404) and try to create the record.
  2. Noted for ipv6 thanks!
  3. Can you try on your end with a wildcard record (assuming you're not needing 100% uptime/production environment)? Even if not possible for you to test it out, let's assume it's supported and wait for someone to create an issue about it if it doesn't work, instead of restricting it to no wildcard if we're not sure.

I'm away from a keyboard until Monday, so feel free to let me know by then if it's too much hassle and I can code it up on your branch, and you can eventually test it out. Thanks!

@jobrajac
Copy link
Contributor Author

3. Can you try on your end with a wildcard record (assuming you're not needing 100% uptime/production environment)? Even if not possible for you to test it out, let's assume it's supported and wait for someone to create an issue about it if it doesn't work, instead of restricting it to no wildcard if we're not sure.

I tested with a wildcard update and it did not work. I can set a wildcard domain in the provider's gui, but the update endpoint will only return 404 unfortunately.

@qdm12
Copy link
Owner

qdm12 commented Sep 15, 2024

Thanks for checking the wildcard record! 👍
How about

If the domain record doesn't exist, what error do they return?

I can jump in on your branch and implement that, no problem 😉 thanks!

@jobrajac
Copy link
Contributor Author

jobrajac commented Sep 24, 2024

Hello. Sorry for the late reply.

I checked the documentation again and it says the record is created if it does not exist. I don't know how I missed this the first time.

I tested it and it works fine:)

Edit: The docs in question
https://api.domeneshop.no/docs/#tag/ddns

@qdm12
Copy link
Owner

qdm12 commented Oct 8, 2024

(I rebased your branch on the repository master branch, and pushed two tiny fixes to fix the CI)

  • about to merge that PR, thanks! 💯

@qdm12 qdm12 merged commit 94e008d into qdm12:master Oct 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants