Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date field to eztv #295

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

ducalex
Copy link
Contributor

@ducalex ducalex commented Aug 17, 2024

(This is a new PR identical to #292 (rebased to current master). I messed up and the other got closed and reopen button was disabled... Sorry!)

They don't provide a convenient format unfortunately, and my parsing might not be exhaustive.

It's also not very accurate when all you have to go by is "1 year [ago]".

But it's certainly better than nothing and seems to work well enough.

image

@xavier2k6
Copy link
Member

“the walrus operator” := was introduced in https://docs.python.org/3/whatsnew/3.8.html

We currently support Python 3.7.0 as our minimum in qBittorrent v4.6.x / v5.0.xbranches.
This is being raised to 3.9.0 in v5.1.x

@Chocobo1 Thoughts?

  1. Should we ignore CI failure
  2. Come up with an alternative
  3. Implement/backport 3.9.0 requirement to v5.0.x branch which brings support for Published on date.

@ducalex ducalex force-pushed the ducalex/add-date-field-eztv2 branch from 0e6a035 to a150c65 Compare August 17, 2024 18:54
@ducalex
Copy link
Contributor Author

ducalex commented Aug 17, 2024

I noticed the CI failure too and I was working on an alternative as you were writing your comment!

The walrus is very useful, it wasn't easy to find an alternate way that is readable and yet not 200 lines.

If either of you have better ideas, by all means, I'm not a python expert :)

Whilst still not very accurate, it is closer to the truth than having all months be 28 days and all years be 364 days...
@Chocobo1
Copy link
Member

Chocobo1 commented Aug 17, 2024

We currently support Python 3.7.0 as our minimum in qBittorrent v4.6.x / v5.0.xbranches.

The plugins should maintain compatibility with Python 3.7.0. A lot of people are still on qbt 4.6.x (or even 4.5.x). It would not be nice if an update makes the plugin unusable.

@xavier2k6 xavier2k6 merged commit b7c4970 into qbittorrent:master Aug 19, 2024
7 checks passed
@xavier2k6
Copy link
Member

@ducalex Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants