Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the speed icons in the status bar #21853

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

mahozad
Copy link
Contributor

@mahozad mahozad commented Nov 15, 2024

The speed icons in the status bar look weird. Whenever I look at them, there seems to be something off with them. The circle seems to have been stretched. Also, the gap between the needle and the circle is not big enough to be clearly visible (at least on my display):

Screenshot (107)

Can that be fixed please?
If you would like, I tried to recreate the icons with Inkscape:

Screenshot (108)

@ArcticGems
Copy link

ArcticGems commented Nov 15, 2024

Using black color will not look good in dark mode.

EDIT: Oh, my mistake. I was in a hurry and made a wrong assumption. Thank you @stalkerok

@mahozad The update looks nice!

@stalkerok
Copy link
Contributor

@ArcticGems You should be looking at the files that have been changed https://github.com/qbittorrent/qBittorrent/pull/21853/files

@Chocobo1 Chocobo1 added the Look and feel Affect UI "Look and feel" only without changing the logic label Nov 16, 2024
@mahozad mahozad force-pushed the master branch 2 times, most recently from 5de2d70 to deb132e Compare November 16, 2024 14:01
Copy link
Member

@Chocobo1 Chocobo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why but I get smaller file sizes when I run them through svgcleaner.

src/icons/slow.svg Outdated Show resolved Hide resolved
src/icons/slow_off.svg Outdated Show resolved Hide resolved
src/icons/speedometer.svg Outdated Show resolved Hide resolved
src/webui/www/private/images/slow.svg Outdated Show resolved Hide resolved
src/webui/www/private/images/slow_off.svg Outdated Show resolved Hide resolved
Something looked off in them (it seemed like they had been stretched). Also, the gap between the needle and the circle was not big enough to be clearly visible
@Chocobo1 Chocobo1 requested a review from a team November 17, 2024 07:35
@Chocobo1 Chocobo1 added this to the 5.1 milestone Nov 18, 2024
@Chocobo1 Chocobo1 changed the title Improve the speed icons used in the status bar Improve the speed icons in the status bar Nov 18, 2024
@Chocobo1 Chocobo1 merged commit 928de36 into qbittorrent:master Nov 18, 2024
14 checks passed
@Chocobo1
Copy link
Member

@mahozad
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Look and feel Affect UI "Look and feel" only without changing the logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants