Refactor: Complete Script Rewrite

[Mycroft-Studios]

Describe Pull request
A complete Rewrite of the script, into a modular based system, benefits of the rewrite include:

• Much easier to read
• Fully documented code
• Easy to follow each part
• Security improvements
• Performance improvements

  from my testing, it goes to 0.02ms max, and that is only for a single tick while dropping off the passenger, the rest of the time it will stay at 0.00ms

• Better coding practices
• Removes almost all threads
• Removes unused Code

Questions (please complete the following information):

• Have you personally loaded this code into an updated qbcore project and checked all it's functionality? Yes
• Does your code fit the style guidelines? Yes
• Does your PR fit the contribution guidelines? Yes

[Jamie9192]

Nicely structured and documented

Ive only scanned through the server lua - a performance improvement would be:

Server.object = exports['qb-core']:GetCoreObject() removed

local GetPlayerObject = exports['qb-core']:GetCoreObject().Functions.GetPlayer caching the single function, instead of the full core.

and call this function to get the players object :)

[Z3rio]

Just nitpicking.
Great PR mate.

[Z3rio]

Only CircleZone is used, no?
I see no usage of EntityZone, BoxZone, ComboZone atleast

[Mycroft-Studios]

maybe?
it has been a good while since i have used PolyZone, so didnt want to break it lol

[Z3rio]

Yeah dont really know personally either, if the CircleZone perhaps depends on one of the other imported files.
If not though, then they should probably be removed to improve performance / overhead, no?

[Mycroft-Studios]

then they should probably be removed to improve performance / overhead, no?

indeed. will do some testing and see if the others are required :)

[Mycroft-Studios]

Nicely structured and documented

Ive only scanned through the server lua - a performance improvement would be:

Server.object = exports['qb-core']:GetCoreObject() removed

local GetPlayerObject = exports['qb-core']:GetCoreObject().Functions.GetPlayer caching the single function, instead of the full core.

and call this function to get the players object :)

Fixed :)