Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uploading results with the same name #649

Merged
merged 1 commit into from
Aug 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions qase-playwright/changelog.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
# [email protected]

## What's new

Fixed the problem when tests have the same name and different QaseIDs.
They were uploaded into the Qase with an incorrect QaseID.

# [email protected]

## What's new
Expand Down
2 changes: 1 addition & 1 deletion qase-playwright/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "playwright-qase-reporter",
"version": "2.0.8",
"version": "2.0.9",
"description": "Qase TMS Playwright Reporter",
"main": "./dist/index.js",
"types": "./dist/index.d.ts",
Expand Down
6 changes: 4 additions & 2 deletions qase-playwright/src/playwright.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,11 @@ export const qase = (
console.log(`qase: qase ID ${id} should be a number`);
}

PlaywrightQaseReporter.addIds(ids, name);
const newName = `${name} (Qase ID: ${caseIds.join(',')})`;

return `${name} (Qase ID: ${caseIds.join(',')})`;
PlaywrightQaseReporter.addIds(ids, newName);

return newName;
};

/**
Expand Down
2 changes: 1 addition & 1 deletion qase-playwright/src/reporter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ export class PlaywrightQaseReporter implements Reporter {
if (testCaseMetadata.ids.length > 0) {
testResult.testops_id = testCaseMetadata.ids;
} else {
const ids = PlaywrightQaseReporter.qaseIds.get(testTitle) ?? null;
const ids = PlaywrightQaseReporter.qaseIds.get(test.title) ?? null;
testResult.testops_id = ids;
if (ids) {
const path = `${test.location.file}:${test.location.line}:${test.location.column}`;
Expand Down
Loading