Skip to content

Commit

Permalink
fix: uploading results with the same name
Browse files Browse the repository at this point in the history
Fixed the problem when tests have the same name and different QaseIDs.
They were uploaded into the Qase with an incorrect QaseID.
  • Loading branch information
gibiw committed Aug 1, 2024
1 parent 267dfe3 commit 09584c4
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 4 deletions.
7 changes: 7 additions & 0 deletions qase-playwright/changelog.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
# [email protected]

## What's new

Fixed the problem when tests have the same name and different QaseIDs.
They were uploaded into the Qase with an incorrect QaseID.

# [email protected]

## What's new
Expand Down
2 changes: 1 addition & 1 deletion qase-playwright/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "playwright-qase-reporter",
"version": "2.0.8",
"version": "2.0.9",
"description": "Qase TMS Playwright Reporter",
"main": "./dist/index.js",
"types": "./dist/index.d.ts",
Expand Down
6 changes: 4 additions & 2 deletions qase-playwright/src/playwright.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,11 @@ export const qase = (
console.log(`qase: qase ID ${id} should be a number`);
}

PlaywrightQaseReporter.addIds(ids, name);
const newName = `${name} (Qase ID: ${caseIds.join(',')})`;

return `${name} (Qase ID: ${caseIds.join(',')})`;
PlaywrightQaseReporter.addIds(ids, newName);

return newName;
};

/**
Expand Down
2 changes: 1 addition & 1 deletion qase-playwright/src/reporter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ export class PlaywrightQaseReporter implements Reporter {
if (testCaseMetadata.ids.length > 0) {
testResult.testops_id = testCaseMetadata.ids;
} else {
const ids = PlaywrightQaseReporter.qaseIds.get(testTitle) ?? null;
const ids = PlaywrightQaseReporter.qaseIds.get(test.title) ?? null;
testResult.testops_id = ids;
if (ids) {
const path = `${test.location.file}:${test.location.line}:${test.location.column}`;
Expand Down

0 comments on commit 09584c4

Please sign in to comment.