-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add min parameter #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. A couple of suggestions if you have time:
- Rebase this branch against master.
- Implement:
impl TryFromV1Parameter<MinParameterV1> for MinParameter
.
We should add docstrings to the schemas as well, but I need to agree a format for these first.
I have opened a new pull request on the schema project. Once that's approved I'll implement Let me know when you've decided abotu the docstring and I'll update the code. Do I need to add a docstring to the parameter as well? |
Thanks I've merged this.
I think we should probably just follow this format: https://doc.rust-lang.org/rust-by-example/meta/doc.html |
I added the docstring to the schema, let me know if it's OK. I also need to pull the new changes from the schema repository, but there is no new version. Can you please push a new tag so that I can update the Cheers |
I'll merge #45 and then merge or rebase this branch against main. |
No description provided.