Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Data table improvements #264

Merged
merged 2 commits into from
Oct 9, 2024
Merged

feat: Data table improvements #264

merged 2 commits into from
Oct 9, 2024

Conversation

jetuk
Copy link
Member

@jetuk jetuk commented Oct 7, 2024

  • More informative error message when failing to load a table reference.
  • Implement loading array data with column headers.

@jetuk jetuk requested a review from Batch21 October 7, 2024 16:14
@jetuk
feat: Data table improvements
42dbe9d 
- More informative error message when failing to load a
table reference.
- Implement loading array data with column headers.
@jetuk jetuk force-pushed the tbl-improvements branch from da82e04 to 42dbe9d Compare October 7, 2024 16:19
Batch21
Batch21 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@Batch21 Batch21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. At some point it would be good to add some docstrings to this module and some more extensive tests. I don't think any of the current test models load data from tables?

@jetuk
Copy link
Member Author

jetuk commented Oct 8, 2024

Agreed. I will add an issue for that.

@jetuk jetuk merged commit 78760fe into main Oct 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Batch21 Batch21 Batch21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jetuk @Batch21