feat: Utilise constant parameters in aggregated node LP creation. #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where possible utilise constant parameters to try to get aggregated node factor pairs during LP creation. This makes it possible to support constant factors in LP solvers without an API for updating the constraint matrix. It should also be generally more efficient by only updating non-constant factors.
Batch21
reviewed
Jul 23, 2024
pywr-core/src/aggregated_node.rs
Outdated
| .collect::<Vec<_>>() | ||
| } else { | ||
| // All factors are available; therefore we can calculate "f0" | ||
| // TODO do we need to assert that each individual factor is positive? |
There was a problem hiding this comment.
to do in this PR? Should it be a general requirement that factors are non-negative checked in the schema?
Batch21
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where possible utilise constant parameters to try to get aggregated node factor pairs during LP creation. This makes it possible to support constant factors in LP solvers without an API for updating the constraint matrix. It should also be generally more efficient by only updating non-constant factors.